[ 
https://issues.apache.org/jira/browse/NIFI-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991864#comment-15991864
 ] 

ASF GitHub Bot commented on NIFI-1833:
--------------------------------------

Github user brosander commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1719#discussion_r114228190
  
    --- Diff: 
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/FetchAzureBlobStorage.java
 ---
    @@ -103,10 +107,15 @@ public void onTrigger(ProcessContext context, 
ProcessSession session) throws Pro
                 session.transfer(flowFile, REL_SUCCESS);
                 final long transferMillis = 
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos);
                 session.getProvenanceReporter().fetch(flowFile, 
blob.getSnapshotQualifiedUri().toString(), transferMillis);
    -
    -        } catch (IllegalArgumentException | URISyntaxException | 
StorageException e1) {
    -            flowFile = session.penalize(flowFile);
    -            session.transfer(flowFile, REL_FAILURE);
    +        } catch (IllegalArgumentException | URISyntaxException | 
StorageException | ProcessException e) {
    +            if (e instanceof ProcessException && storedException.get() == 
null) {
    +                throw (ProcessException) e;
    +            } else {
    +                Exception failureException = 
Optional.ofNullable(storedException.get()).map(x -> x).orElse(e);
    --- End diff --
    
    @jtstorck I don't think you need the .map() here.  It looks like 
[orElse()](https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html#orElse-T-)
 will already give you the value if the optional is absent.


> Add support for Azure Blob Storage and Table Storage
> ----------------------------------------------------
>
>                 Key: NIFI-1833
>                 URL: https://issues.apache.org/jira/browse/NIFI-1833
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.6.1
>            Reporter: Simon Elliston Ball
>            Assignee: Jeff Storck
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> It would be useful to have an Azure equivalent of the current S3 capability. 
> Azure also provides a Table storage mechanism, providing simple key value 
> storage. Since the Azure SDKs are Apache Licensed, this should be reasonably 
> straightforward. A first cut is available as an addition to the existing 
> azure bundle.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to