GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1751
NIFI-3796 Fixed Windows test failures due to POSIX permissions
I separated the unit test for unreadable and missing files into two
distinct tests and skipped the unreadable one for Windows. Windows is not
POSIX-compliant and the `File.setReadable()` method is not working to mock the
unreadable file situation.
Confirmed this ran on Windows 10.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-3796
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1751
----
commit af741325437bf9c8b754fe848e1d0ca9382f3ec1
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-05-04T14:30:38Z
NIFI-3796 Added test logic to only run POSIX permission set on *nix OS.
commit d111f97884ad5c9794dc37712aa9f871442e2ef3
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-05-04T15:16:21Z
NIFI-3796 Separated missing and unreadable key providers to different tests
and run unreadable on POSIX-compliant OS only.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
