[
https://issues.apache.org/jira/browse/NIFI-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996912#comment-15996912
]
ASF GitHub Bot commented on NIFI-3796:
--------------------------------------
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1751
NIFI-3796 Fixed Windows test failures due to POSIX permissions
I separated the unit test for unreadable and missing files into two
distinct tests and skipped the unreadable one for Windows. Windows is not
POSIX-compliant and the `File.setReadable()` method is not working to mock the
unreadable file situation.
Confirmed this ran on Windows 10.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-3796
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1751
----
commit af741325437bf9c8b754fe848e1d0ca9382f3ec1
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-05-04T14:30:38Z
NIFI-3796 Added test logic to only run POSIX permission set on *nix OS.
commit d111f97884ad5c9794dc37712aa9f871442e2ef3
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-05-04T15:16:21Z
NIFI-3796 Separated missing and unreadable key providers to different tests
and run unreadable on POSIX-compliant OS only.
----
> Encrypted provenance repository test failure on Win10
> -----------------------------------------------------
>
> Key: NIFI-3796
> URL: https://issues.apache.org/jira/browse/NIFI-3796
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00)
> Maven home: C:\development\tools\apache-maven-3.3.9
> Java version: 1.8.0_102, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_102\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
> Reporter: Joseph Witt
> Assignee: Andy LoPresto
> Priority: Critical
> Fix For: 1.2.0
>
>
> {code}
> Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.109 sec
> <<< FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest
> testShouldNotValidateUnreadableOrMissingFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest)
> Time elapsed: 0.016 sec <<< ERROR!
> java.lang.UnsupportedOperationException: null
> at java.nio.file.Files.setPosixFilePermissions(Files.java:2044)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
> at
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.invoke(StaticMetaMethodSite.java:46)
> at
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:91)
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> at
> org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableOrMissingFileBasedKeyProvider(CryptoUtilsTest.groovy:187)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
