Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1772#discussion_r115555861 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/ArrayIndexFieldValue.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.record.path; + +import java.util.Objects; + +import org.apache.nifi.serialization.record.RecordField; +import org.apache.nifi.serialization.record.RecordFieldType; + +public class ArrayIndexFieldValue extends StandardFieldValue { + private final int index; + + public ArrayIndexFieldValue(final Object value, final RecordField field, final FieldValue parent, final int index) { + super(value, field, validateParent(parent)); + this.index = index; + } + + private static FieldValue validateParent(final FieldValue parent) { + Objects.requireNonNull(parent, "Cannot create an ArrayIndexFieldValue without a parent"); + if (RecordFieldType.ARRAY != parent.getField().getDataType().getFieldType()) { + // TODO: Add Unit test that does something like //myArray[../name = 'myName'][0] and ensure that --- End diff -- Check your TODOs please to see which should stay and which can go :)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---