Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1775
@tequalsme thanks again for contributing this cool upgrade to
PutCloudWatchMetric. First, a couple of nickpicks:
* PropertyDescriptor `name` should be a data key, typically lowercase, like
"minimum". The `displayName` property should have a human-readable name
"Minimum". Although the names and displayNames might be very similar now, this
helps provide flexibility for later changes. I realize we didn't follow that
convention creating PutCloudWatchMetric, and your changes are following the
pattern established in the file. In this case, we should be different.
* I found a Checkstyle warning for "Unused import - java.util.Comparator"
(for TestPutCloudWatchMetric) running `mvn clean install -Pcontrib-check`.
The processor performed well under proper use. So I moved on to improper
use. For the statistic set scenario, if I provided some but not all of
Minimum, Maximum, Sum, and SampleCount, the processor did not raise a
validation issue and later ran into a NullPointerException parsing a double
from Minimum (in this case). How about a validation clause to make sure you
specified something for all four?
Other validations worked well. Help/docs look good. Code coverage from
unit tests is great. Code quality looks very high.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
