[
https://issues.apache.org/jira/browse/NIFI-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009705#comment-16009705
]
ASF GitHub Bot commented on NIFI-1709:
--------------------------------------
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1794
NIFI-1709 - Introduce logic to probe Linux version using /etc/os-rele…
…ase to nifi.sh
Add explicit paths to support SLES 11 SP4 / OpenSUSE init.d
layout
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] ~~~Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?~~~
- [X] ~~~Have you written or updated unit tests to verify your changes?~~~
- [X] ~~~If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?~~~
- [X] ~~~If applicable, have you updated the LICENSE file, including the
main LICENSE file under nifi-assembly?~~~
- [X] ~~~If applicable, have you updated the NOTICE file, including the
main NOTICE file found under nifi-assembly?~~~
- [X] ~~~If adding new Properties, have you added .displayName in addition
to .name (programmatic access) for each of the new properties?~~~
### For documentation related changes:
- [X] ~~~Have you ensured that format looks appropriate for the output in
which it is rendered?~~~
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-1709
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1794.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1794
----
commit 4be08841dcd1e315c8fbec9ac81377155366f75f
Author: Andre F de Miranda <trix...@users.noreply.github.com>
Date: 2017-05-14T12:14:33Z
NIFI-1709 - Introduce logic to probe Linux version using /etc/os-release to
nifi.sh
Add explicit paths to support SLES 11 SP4 / OpenSUSE init.d
layout
----
> The nifi.sh install script assumes RHEL directories
> ---------------------------------------------------
>
> Key: NIFI-1709
> URL: https://issues.apache.org/jira/browse/NIFI-1709
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Environment: SUSE
> Reporter: David A. Wynne
> Assignee: Andre F de Miranda
> Priority: Minor
>
> When setting up NiFi, the command:
> bin/nifi.sh install
> The following error occurs:
> ln: failed to create symbolic link `/etc/rc2.d/S65nifi': No such file or
> directory
> ln: failed to create symbolic link `/etc/rc2.d/K65nifi': No such file or
> directory
> Service nifi installed
> Looking in the nifi.sh, around line 145 - 148, you see:
> rm -f "/etc/rc2.d/S65${SVC_NAME}"
> ln -s "/etc/init.d/${SVC_NAME}" "/etc/rc2.d/S65${SVC_NAME}"
> rm -f "/etc/rc2.d/K65${SVC_NAME}"
> ln -s "/etc/init.d/${SVC_NAME}" "/etc/rc2.d/K65${SVC_NAME}"
> It tries to symlink from /etc/init.d/nifi to /etc/rc2.d/S65nifi (and
> K65nifi).
> The problem is that the script assumes that /etc/rc2.d exists in a SUSE
> system, which it doesn't.
> In Suse11, this directory is /etc/init.d/rc2.d/
> The script, especially the "install" option should correctly identify the OS
> flavor it runs on, and install the files in the correct location.
> The next version of RHEL (8, not out yet), and Ubuntu 16.02 LTS (releasing
> next month), will use systemD, which does not have the concept of /etc/rc2.d
> directories, but works with "targets". The script will not be compatible with
> these OS changes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
