[ https://issues.apache.org/jira/browse/NIFI-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010222#comment-16010222 ]
ASF GitHub Bot commented on NIFI-2624: -------------------------------------- GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1798 NIFI-2624: Avro logical types for ExecuteSQL and QueryDatabaseTable Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijokarumawak/nifi nifi-2624 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1798.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1798 ---- commit 1667654700d277670e08cc13f009af9060245fce Author: Koji Kawamura <ijokaruma...@apache.org> Date: 2017-05-12T04:30:31Z NIFI-3873: Improve Avro logical types readability commit 2a07a830aeb1b79f5267c7f7d95f95b855ed7c61 Author: Koji Kawamura <ijokaruma...@apache.org> Date: 2017-05-15T02:26:30Z NIFI-3895: Fixed AvroReader to use Schema Access Strategy default value properly. commit 6c3080f5cc9662f45cf8792831eb25ee235a75dd Author: Koji Kawamura <ijokaruma...@apache.org> Date: 2017-01-24T03:16:52Z NIFI-2624: Avro logical types for ExecuteSQL and QueryDatabaseTable - Added Logical type support for DECIMAL/NUMBER, DATE, TIME and TIMESTAMP column types. - Added Logical type 'decimal' to AvroReader so that Avro records with logical types written by ExecuteSQL and QueryDatabaseTable can be consumed by AvroReader. - Added JdbcCommon.AvroConversionOptions to consolidate conversion options. - Added 'Use Avro Logical Types' property to ExecuteSQL and QueryDatabaseTable to toggle whether to use Logical types. - Added 'mime.type' FlowFile attribute as 'application/avro-binary' so that output FlowFiles can be displayed by content viewer. ---- > JDBC-to-Avro processors handle BigDecimals as Strings > ----------------------------------------------------- > > Key: NIFI-2624 > URL: https://issues.apache.org/jira/browse/NIFI-2624 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions > Reporter: Matt Burgess > Assignee: Toivo Adams > > The original SQL processors implemented BigDecimal values as Strings for > Avro, as the version of Avro it used (1.7.6) did not support DECIMAL type. > As of Avro 1.7.7 (AVRO-1402), this type is supported and so the SQL/HiveQL > processors should be updated to handle BigDecimals correctly if possible. -- This message was sent by Atlassian JIRA (v6.3.15#6346)