Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116982739
  
    --- Diff: libminifi/test/resources/cn.ckey.pem ---
    @@ -0,0 +1,31 @@
    +Bag Attributes
    --- End diff --
    
    Might not be a bad idea, but not necessary.  At some point we can look into 
getting the Apache RAT running against our source and list as exclusions.  
Actually, perhaps even just enumerating such resources on the wiki until we get 
a more formal check in place would be sufficient.  I had started the following 
https://cwiki.apache.org/confluence/display/MINIFI/Licensing+Information (and 
clearly forgot about updating it) a little while ago.  Maybe we can just 
highlight such files here after merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to