[ 
https://issues.apache.org/jira/browse/NIFI-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016865#comment-16016865
 ] 

ASF GitHub Bot commented on NIFI-3940:
--------------------------------------

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1827
  
    The issue is that `jython` uses a binary build instead of Maven so it is an 
"unshaded JAR" (described in far more detail 
[here](https://github.com/scijava/jython-shaded)). It includes libraries that 
conflict with `jruby` but Maven can't resolve them, so there are runtime 
errors. 
    
    Rather than separate the dependencies into separate modules, we can use the 
`jython-shaded` dependency mentioned above to resolve this. 
    
    I can't push the changes to this branch, but you can make the following 
changes in `nifi-scripting-processor/pom.xml`:
    
    ```
        <dependency>
            <groupId>org.python</groupId>
            <artifactId>jython-standalone</artifactId>
            <version>2.7.1b3</version>
        </dependency>
    ```
    
    with
    
    ```
    <dependency>
        <groupId>org.scijava</groupId>
        <artifactId>jython-shaded</artifactId>
        <version>2.7.0</version>
    </dependency>
    ```
    
    Tests all pass:
    
    ```
    -------------------------------------------------------
     T E S T S
    -------------------------------------------------------
    Running org.apache.nifi.processors.script.ExecuteScriptGroovyTest
    Tests run: 4, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 2.533 sec - 
in org.apache.nifi.processors.script.ExecuteScriptGroovyTest
    Running org.apache.nifi.processors.script.TestExecuteClojure
    Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.029 sec - 
in org.apache.nifi.processors.script.TestExecuteClojure
    Running org.apache.nifi.processors.script.TestExecuteGroovy
    Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.648 sec 
- in org.apache.nifi.processors.script.TestExecuteGroovy
    Running org.apache.nifi.processors.script.TestExecuteJavascript
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.979 sec - 
in org.apache.nifi.processors.script.TestExecuteJavascript
    Running org.apache.nifi.processors.script.TestExecuteJRuby
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.77 sec - 
in org.apache.nifi.processors.script.TestExecuteJRuby
    Running org.apache.nifi.processors.script.TestExecuteJython
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.72 sec - 
in org.apache.nifi.processors.script.TestExecuteJython
    Running org.apache.nifi.processors.script.TestExecuteLua
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.068 sec - 
in org.apache.nifi.processors.script.TestExecuteLua
    Running org.apache.nifi.processors.script.TestInvokeGroovy
    Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.517 sec - 
in org.apache.nifi.processors.script.TestInvokeGroovy
    Running org.apache.nifi.processors.script.TestInvokeJavascript
    Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.396 sec - 
in org.apache.nifi.processors.script.TestInvokeJavascript
    Running org.apache.nifi.processors.script.TestInvokeJython
    Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.263 sec - 
in org.apache.nifi.processors.script.TestInvokeJython
    Running org.apache.nifi.record.script.ScriptedReaderTest
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.515 sec - 
in org.apache.nifi.record.script.ScriptedReaderTest
    Running org.apache.nifi.record.script.ScriptedRecordSetWriterTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.24 sec - 
in org.apache.nifi.record.script.ScriptedRecordSetWriterTest
    Running org.apache.nifi.reporting.script.ScriptedReportingTaskGroovyTest
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.269 sec - 
in org.apache.nifi.reporting.script.ScriptedReportingTaskGroovyTest
    
    Results :
    
    
    
    
    Tests run: 45, Failures: 0, Errors: 0, Skipped: 1
    ```


> older jruby-complete artifacts contained LGPL code
> --------------------------------------------------
>
>                 Key: NIFI-3940
>                 URL: https://issues.apache.org/jira/browse/NIFI-3940
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.2.0
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> From Mike Drob's report to legal
> Legal,
> I recently got done working with the JRuby dev team on an issue where they 
> were inadvertently including LGPL code in the jruby-complete jar for versions 
> 9.0.0.0 - 9.1.8.0.
> I'm not sure if we have a good mechanism for tracking which projects are 
> using/bundling JRuby, but it would be good to let them know that they should 
> consider updating for license reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to