[ https://issues.apache.org/jira/browse/NIFI-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017934#comment-16017934 ]
ASF GitHub Bot commented on NIFI-1452: -------------------------------------- GitHub user mosermw opened a pull request: https://github.com/apache/nifi/pull/1832 NIFI-1452 on timer-driven yield, use the greater of yield duration or run schedule Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mosermw/nifi NIFI-1452 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1832.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1832 ---- commit 7d376af5020226da8e036c602fb90cfeb0530714 Author: Mike Moser <mose...@apache.org> Date: 2017-05-19T19:48:10Z NIFI-1452 on timer-driven yield, use the greater of yield duration or run schedule ---- > Yield Duration can short circuit long Timer Driven Run Schedule > --------------------------------------------------------------- > > Key: NIFI-1452 > URL: https://issues.apache.org/jira/browse/NIFI-1452 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework > Affects Versions: 0.4.1 > Reporter: Michael Moser > Assignee: Michael Moser > Priority: Trivial > > This may be a rare use case, but I configured a GetFile processor to be Timer > Driven with a Run Schedule of 30 secs. Its Yield Duration was default 1 sec. > I expected GetFile onTrigger() to be called every 30 secs, but it was being > called every 1 sec most of the time. > GetFile will call context.yield() when it polls a directory and gets an empty > list in return. It appears that a yield will ignore the Run Schedule. Many > standard processors call context.yield() when they have no work to do. > I changed my scheduling strategy to CRON Driven with its run schedule every > 30 seconds, and the onTrigger() was called every 30 seconds, even after a > yield. So CRON Driven scheduling is working as expected after a yield. -- This message was sent by Atlassian JIRA (v6.3.15#6346)