[ 
https://issues.apache.org/jira/browse/NIFI-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022584#comment-16022584
 ] 

ASF GitHub Bot commented on NIFI-3809:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1754#discussion_r118202031
  
    --- Diff: 
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/AbstractSiteToSiteReportingTask.java
 ---
    @@ -73,25 +80,65 @@
                 .build();
         static final PropertyDescriptor COMPRESS = new 
PropertyDescriptor.Builder()
                 .name("Compress Events")
    +            .displayName("Compress Events")
                 .description("Indicates whether or not to compress the data 
being sent.")
                 .required(true)
                 .allowableValues("true", "false")
                 .defaultValue("true")
                 .build();
         static final PropertyDescriptor TIMEOUT = new 
PropertyDescriptor.Builder()
                 .name("Communications Timeout")
    +            .displayName("Communications Timeout")
                 .description("Specifies how long to wait to a response from 
the destination before deciding that an error has occurred and canceling the 
transaction")
                 .required(true)
                 .defaultValue("30 secs")
                 .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
                 .build();
         static final PropertyDescriptor BATCH_SIZE = new 
PropertyDescriptor.Builder()
                 .name("Batch Size")
    +            .displayName("Batch Size")
                 .description("Specifies how many records to send in a single 
batch, at most.")
                 .required(true)
                 .defaultValue("1000")
                 .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
                 .build();
    +    static final PropertyDescriptor TRANSPORT_PROTOCOL = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    If I am not missing anything, these newly added PropertyDescriptors should 
be used by sub classes such as SiteToSiteBulletinReportingTask?


> S2S Reporting tasks should provide the option to choose transport protocol
> --------------------------------------------------------------------------
>
>                 Key: NIFI-3809
>                 URL: https://issues.apache.org/jira/browse/NIFI-3809
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.2.0
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>
> Right now Site-to-Site based reporting tasks are using the default RAW 
> protocol but some users might not want to open a port for that. It should be 
> possible to use HTTP.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to