Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1830
@jfrazee @mattyb149 I reviewed the updated commit and found few points to
improve.
I was trying to comment all of those, but since it's easier to explain with
code instead of comment, I created another PR based on this one.
@jfrazee Would you take a look on #1856 to see if those changes are
reasonable? Please find the [commit
comments](https://github.com/apache/nifi/pull/1856/commits/4f81af0961c3d65c4df37b9de3934c8fed1a70ff)
for what I've changed. If my additional commit looks ok, then I'd give +1 to
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
