[
https://issues.apache.org/jira/browse/NIFI-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024763#comment-16024763
]
ASF GitHub Bot commented on NIFI-3976:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1857
NIFI-3976: Fix ConsumePOP3 and ConsumeIMAP to delete messages.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3976
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1857
----
commit 579b7a46e07c30651cf4e2ed76207c48eb04e3ea
Author: Koji Kawamura <ijokaruma...@apache.org>
Date: 2017-05-25T13:56:12Z
NIFI-3976: Fix ConsumePOP3 and ConsumeIMAP to delete messages.
----
> ConsumePOP3 and ConsumeIMAP do NOT delete messages
> --------------------------------------------------
>
> Key: NIFI-3976
> URL: https://issues.apache.org/jira/browse/NIFI-3976
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> Those processors have 'Delete Messages' property but even if user configured
> it to 'true' messages are not deleted from mail server.
> AbstractEmailProcessor which is a superclass for both processors, has been
> using:
> {code}
> emailMessage.setFlag(Flags.Flag.DELETED, this.shouldSetDeleteFlag);
> {code}
> However, since we are using Spring mail, the underlying receiver does not
> close the inbox connection so messages are not deleted.
> Instead, we should use:
> {code}
> receiver.setShouldDeleteMessages(boolean)
> {code}
> To specify whether it should delete fetched messages or not.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
