Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118496711
--- Diff: libminifi/include/Site2SitePeer.h ---
@@ -72,8 +73,8 @@ class Site2SitePeer : public
org::apache::nifi::minifi::io::BaseStream {
explicit Site2SitePeer(Site2SitePeer &&ss)
: stream_(ss.stream_.release()),
host_(std::move(ss.host_)),
- port_(std::move(ss.port_)) {
- logger_ = logging::Logger::getLogger();
+ port_(std::move(ss.port_)),
+ logger_(ss.logger_) {
--- End diff --
since we are using move semantics here we should move the object and not
reference it. Since we were using a shared object before it didn't really make
any sense but since this is per class we should do std::move(ss.logger_)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
