[ 
https://issues.apache.org/jira/browse/NIFI-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046044#comment-16046044
 ] 

Adam Taft commented on NIFI-4057:
---------------------------------

This is a good catch and will be super easy to fix.

There are some  other cleanup areas that might want to be considered in the 
same patch.  I'm wondering about:

-  GID=50 already exists in openjdk:8 (staff).  Why are we attempting to use 
and rename an existing group?  Just create a new group and be done with it?

-  Consolidate the "Setup NiFi user" into a single layer.  Combine any 
groupadd, useradd, mkdir, chown statements into a single RUN layer.

-  Update the deprecated MAINTAINER statement with "LABEL maintainer"


> Docker Image is twice as large as necessary
> -------------------------------------------
>
>                 Key: NIFI-4057
>                 URL: https://issues.apache.org/jira/browse/NIFI-4057
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Docker
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Jordan Moore
>            Priority: Minor
>
> By calling {{chown}} as a secondary {{RUN}} command, you effectively double 
> the size of image by creating a Docker layer of the same size as the 
> extracted binary. 
> See GitHub discussion: 
> https://github.com/apache/nifi/pull/1372#issuecomment-307592287
> *Expectation*
> The resultant Docker image should be no larger than the Base image + the size 
> required by extracting the Nifi binaries. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to