[ 
https://issues.apache.org/jira/browse/NIFI-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052452#comment-16052452
 ] 

ASF GitHub Bot commented on NIFI-2692:
--------------------------------------

GitHub user cherrera2001 opened a pull request:

    https://github.com/apache/nifi/pull/1924

    NIFI-2692: Fix for TestListenSMTP tests fail

    - Removing problematic timeout for SMTP Listen
    - Converting anonymous method to lambda
    - Adding debug and error logging
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message? NIFI-2692
    
    - [x ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cherrera2001/nifi NIFI-2692

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1924.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1924
    
----
commit 6051e81246ba73be487971b800199754601a40cc
Author: Chris Herrera <chris.herr...@hashmapinc.com>
Date:   2017-06-16T22:24:35Z

    NIFI-2692
    
    - Removing problematic timeout for SMTP Listen
    - Converting anonymous method to lambda
    - Adding debug and error logging

----


> TestListenSMTP tests fail on Windows 10
> ---------------------------------------
>
>                 Key: NIFI-2692
>                 URL: https://issues.apache.org/jira/browse/NIFI-2692
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Aldrin Piri
>            Assignee: Chris Herrera
>
> All tests within TestListenSMTP fail on Windows 10 as initially reported by 
> [~jskora] and confirmed by myself while building.  These items seem to 
> timeout in that environment and with extended periods, seem to pass 
> successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to