[ https://issues.apache.org/jira/browse/NIFI-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072252#comment-16072252 ]
ASF GitHub Bot commented on NIFI-438: ------------------------------------- GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1970 NIFI-438 - added ConditionalIgnoreRule to run tests based env conditions Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-438 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1970.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1970 ---- commit 186647dc1b8e116cf2ab3b62d90d4222f4467c04 Author: Pierre Villard <pierre.villard...@gmail.com> Date: 2017-07-03T10:52:10Z NIFI-438 - added ConditionalIgnoreRule to run tests based env conditions ---- > If tests could talk they'd say 'Do not @Ignore me' > -------------------------------------------------- > > Key: NIFI-438 > URL: https://issues.apache.org/jira/browse/NIFI-438 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions > Affects Versions: 0.0.2 > Reporter: Joseph Witt > Attachments: IGNORED-TESTS.partyfoul > > > We have accumulated a lot of @Ignored tests. Some are for good reasons but > we need to find alternatives of activating/deactivating. If something > doesn't run on windows then we skip it there. Attached a listing of the > instances of @Ignore found. -- This message was sent by Atlassian JIRA (v6.4.14#64029)