Github user kevdoran commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/114
  
    @benqiu2016 thanks for making that round of changes! They look good. I'll 
be happy to test the branch when a get a chance to setup a NiFi environment 
that I can use to test some of the more advanced configurations that are 
supported (clustered peers, secure client). I should have a chance to do that 
this week, hopefully in the next couple days. As a general comment, it looks 
like there are quite a few cases that are not covered by corresponding 
automated tests so a lot of this will rely manual verification. You may want to 
open a JIRA ticket for adding some additional unit tests and integration tests 
as a way to verify this feature over time as changes are made to the codebase. 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to