Github user mosermw commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2010#discussion_r128633148
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
 ---
    @@ -149,6 +154,10 @@ public FileSystemRepository(final NiFiProperties 
nifiProperties) throws IOExcept
             for (final Path path : fileRespositoryPaths.values()) {
                 Files.createDirectories(path);
             }
    +        this.maxFlowFilesPerClaim = 
nifiProperties.getMaxFlowFilesPerClaim();
    +        this.writableClaimQueue  = new 
LinkedBlockingQueue<>(maxFlowFilesPerClaim);
    +        final String maxAppendableClaimSize = 
nifiProperties.getMaxAppendableClaimSize();
    +        this.maxAppendableClaimLength = 
DataUnit.parseDataSize(maxAppendableClaimSize, DataUnit.B).intValue();
    --- End diff --
    
    In my opinion, I don't see anything wrong with a static cap, as long as 
it's reasonably big enough (the 100 MB choice).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to