Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2030
Overall, this looks good - tests pass, integration tests pass, refactoring
of integration test credentials is nice, code looks good. In my basic testing,
it deleted objects from RethinkDB just fine. I have a few questions about the
**Return old Changes from the delete** option, and how it is processed. I am
not very familiar with RethinkDB, so I had to check the [delete
docs](https://rethinkdb.com/api/java/delete/) on how it works. I have no
practical experience using this option.
* Instead of a true/false dropdown list, you made this a free text field
supporting expression language. May I ask why? I think it would be easier to
edit if we did, and easier to understand if we made the options more
explanatory ("Capture changes as FlowFile content", "Do not capture changes",
or something like that).
* If the option is true, the processor writes the changes to the attribute
`rethinkdb.delete.changes`, the changes are also contained in the entire raw
`attribute rethinkdb.delete.result` attribute, and finally the changes are
written to the flowfile content. Do we need all of those?
* In the event that the deleted document is large, the attributes will be
large, and potentially unusable due to truncation at 64KB.
* The modify provenance event is reported regardless of this setting.
Shouldn't we only do that if a change is made?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
