Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r130400960
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -84,6 +86,14 @@
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ protected static final PropertyDescriptor INSERT_OPERATION = new
PropertyDescriptor.Builder()
+ .name("INSERT OPERATION")
+ .description("Specify operation for this processor.
Insert-Ignore will ignore duplicated rows")
+ .allowableValues("Insert", "Insert-Ignore", "Upsert")
--- End diff --
It's generally best practice for us to use an Enum instead of a list of
strings when using `allowableValues`..it mainly just lends itself to cleaner
looking code later down the road.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
