Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2051#discussion_r131983689
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
---
@@ -821,6 +925,46 @@ public ScheduleComponentsEntity
scheduleComponents(final String processGroupId,
}
@Override
+ public ActivateControllerServicesEntity
activateControllerServices(final String processGroupId, final
ControllerServiceState state, final Map<String, Revision> serviceRevisions) {
+
+ final NiFiUser user = NiFiUserUtils.getNiFiUser();
+ return activateControllerServices(user, processGroupId, state,
serviceRevisions);
+ }
+
+ @Override
+ public ActivateControllerServicesEntity
activateControllerServices(final NiFiUser user, final String processGroupId,
final ControllerServiceState state,
--- End diff --
`NiFiServiceFacadeLock` handles read/write locking based on the method
name. Assuming this method needs that thread safety, the name of this method
needs to be accounted for. Either by changing it here or adding another advice
to intercept this method call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
