Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2051#discussion_r132472005
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
---
@@ -314,7 +430,7 @@ public Response updateProcessGroup(
Authorizable authorizable =
lookup.getProcessGroup(id).getAuthorizable();
authorizable.authorize(authorizer,
RequestAction.WRITE, NiFiUserUtils.getNiFiUser());
},
- null,
+ () ->
serviceFacade.verifyUpdateProcessGroup(requestProcessGroupDTO),
--- End diff --
Good call. Originally, I had it updating the variables here but then
refactored quite a bit. I think it's best to go ahead and leave in the addition
of the verifyUpdateProcessGroup method, but make the verification a NOP. We do
this in a few other places, as well, so I feel it's best to leave the
'plumbing' there, since it's already been built. It will make it easier to
update later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
