Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2050#discussion_r132612494
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
 ---
    @@ -259,6 +261,11 @@ public void onTrigger(final ProcessContext context, 
final ProcessSessionFactory
                     }
                 });
     
    +            if(customWhereClause != null) {
    +                // adding the custom WHERE clause (if defined) to the list 
of existing clauses.
    +                maxValueClauses.add(customWhereClause);
    --- End diff --
    
    What do you think about forcing custom where clauses to be surrounded with 
parenthesis?
    I worry that just putting it in like this may cause unexpected consequences 
if the where clauses includes OR's.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to