GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/2077
NIFI-4237 Improve error messaging on encryption failures
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-4237
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2077.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2077
----
commit 5752925ac51035db1a5e9f7e9797e308fc5770f2
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-08-11T20:15:16Z
NIFI-4237 Added working test for StringEncryptor decryption of sensitive
flow values in FlowFromDOMFactory.
commit 7c35cfccb2868814184aa4768ee398d0038eaab1
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-08-11T20:17:09Z
NIFI-4237 Cleaned up unused alternate approaches.
commit a45a259a99a176aea848190d23253a54e88aed95
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-08-11T20:20:11Z
NIFI-4237 Added failing unit test for better error message.
commit 1a2a4ddebdd506b058b359747f0a1016a6ff3346
Author: Andy LoPresto <alopre...@apache.org>
Date: 2017-08-11T20:30:44Z
NIFI-4237 Added logic to capture unhelpful encryption exception and provide
context in message.
All tests pass.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
