[
https://issues.apache.org/jira/browse/NIFIREG-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135443#comment-16135443
]
ASF GitHub Bot commented on NIFIREG-7:
--------------------------------------
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/5#discussion_r134273595
--- Diff:
nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/flow/FlowProvider.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.registry.flow;
+
+import org.apache.nifi.registry.provider.Provider;
+
+/**
+ * A service that can store and retrieve versioned flow snapshots.
+ *
+ * NOTE: Although this interface is intended to be an extension point, it
is not yet considered stable and thus may
+ * change across releases until the registry matures.
+ */
+public interface FlowProvider extends Provider {
--- End diff --
Would a better name be "FlowPersistenceProvider" as this seems to primarily
define methods for persistence operations for flows whereas other types of
operations are defined in the MetadataProvider? Or do you think other
operations will get added to FlowProvider over time other than persistence?
I want to make sure I fully understand how the two Providers you have in
this PR are intended to be used together. Is it designed so that atomic
operations, such as generating new version numbers, are done via the
MetadataProvider and then the snapshot would be saved/persisted via the
FlowProvider? Eventually we will probably want to add search (ie, search for
flow by name). Do you envision that would be added to the MetadataProvider or
FlowProvider? Again, not requesting a change in this case, just want to make
sure I follow your thinking.
> Define Flow Persistence Provider Interface
> ------------------------------------------
>
> Key: NIFIREG-7
> URL: https://issues.apache.org/jira/browse/NIFIREG-7
> Project: NiFi Registry
> Issue Type: Improvement
> Reporter: Bryan Bende
> Assignee: Bryan Bende
>
> The Flow Persistence Provider will be the interface that the REST/service
> layer uses to perform CRUD operations on versioned flows. The implementation
> used by the application should be configurable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
