[ https://issues.apache.org/jira/browse/NIFI-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136133#comment-16136133 ]
ASF GitHub Bot commented on NIFI-4169: -------------------------------------- GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/2105 NIFI-4169: WIP PutWebSocket broadcast failure handling **NOTE** Submitting this PR just for code review purpose. Not ready to be merged yet. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijokarumawak/nifi nifi-4169 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2105 ---- commit 8ca63ae87b0dfe6c44f9d1f0ef86167968df26cd Author: Koji Kawamura <ijokaruma...@apache.org> Date: 2017-08-21T22:47:23Z Contribution from Y Wikander. commit 2f0dfe1be9df4e59d3128924d386d382fb1850b1 Author: Koji Kawamura <ijokaruma...@apache.org> Date: 2017-08-22T01:30:37Z NIFI-4169: WIP PutWebSocket broadcast failure handling ---- > PutWebSocket processor with blank WebSocket session id attribute cannot > transfer to failure queue > ------------------------------------------------------------------------------------------------- > > Key: NIFI-4169 > URL: https://issues.apache.org/jira/browse/NIFI-4169 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions > Affects Versions: 1.3.0 > Reporter: Y Wikander > Labels: patch > Attachments: > 0001-websocket-when-sendMessage-fails-under-blank-session.patch, > 0002-websocket-PutWebSocket-enhance-broadcast-support.patch > > > If a PutWebSocket processor is setup with a blank WebSocket session id > attribute (see NIFI-3318; Send message from PutWebSocket to all connected > clients) and it is not connected to a websocket server it will log the > failure and mark the flowfile with Success (rather than Failure) -- and the > data is effectively lost. > If there are multiple connected clients, and some succeed and others fail, > routing Failure back into the PutWebSocket could result in duplicate data to > some clients. > Other NiFi processors seem to err on the side of "at least once". -- This message was sent by Atlassian JIRA (v6.4.14#64029)