Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1877
  
    @markap14 Thanks for pointing that out. I think I got mislead by the two 
getSchema methods in SchemaRegistryService. I accidentally removed the 2nd form 
during refactoring and that caused for the unnecessary InputStream sneaked into 
RecordSetWriterFactory.
    
    ```
        // This one had been used by readers
        public final RecordSchema getSchema(final FlowFile flowFile, final 
InputStream contentStream, final RecordSchema readSchema) throws 
SchemaNotFoundException, IOException {
        // This one had been used by writers
        public RecordSchema getSchema(final FlowFile flowFile, final 
RecordSchema readSchema) throws SchemaNotFoundException, IOException {
    ```
    
    I pushed another commit to bring back the 2nd signature above, and change 
FlowFile to Map<String, String>. Compiled and contrib-check passed locally. 
Also tested different readers/writers with a live flow. Thanks again for your 
time to review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to