Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2088#discussion_r136160691
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockConfigurationContext.java ---
@@ -58,8 +58,12 @@ public MockConfigurationContext(final ControllerService
service,
@Override
public PropertyValue getProperty(final PropertyDescriptor property) {
- String value = properties.get(property);
--- End diff --
@Wesley-Lawrence I don't think this is really what we want here. The
concept of a default value is 'use this if the value is null'. So changing this
would be inconsistent with how the StandardProcessContext works as well. I
think the more desirable approach would be to just update the
SingleCharacterValidator being used such that we allow 0 or 1 character. Then,
this would allow an empty string to be used as the delimiter, which I believe
is equivalent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
