Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r137020354 --- Diff: libminifi/include/processors/BinFiles.h --- @@ -0,0 +1,295 @@ +/** + * @file BinFiles.h + * BinFiles class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef __BIN_FILES_H__ +#define __BIN_FILES_H__ + +#include <climits> +#include <deque> +#include <map> +#include "FlowFileRecord.h" +#include "core/Processor.h" +#include "core/ProcessSession.h" +#include "core/Core.h" +#include "core/Resource.h" +#include "core/logging/LoggerConfiguration.h" +#include "utils/Id.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace processors { + +// Bin Class +class Bin { + public: + // Constructor + /*! + * Create a new Bin --- End diff -- We should have a comment that this object is not thread safe.
---