[
https://issues.apache.org/jira/browse/NIFI-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159202#comment-16159202
]
ASF GitHub Bot commented on NIFI-4341:
--------------------------------------
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2119#discussion_r137878394
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/SystemDiagnosticsSnapshotDTO.java
---
@@ -361,6 +371,12 @@ public SystemDiagnosticsSnapshotDTO clone() {
contentRepoStorageUsage.add(usage.clone());
}
+ final Set<StorageUsageDTO> provenanceRepoStorageUsage = new
LinkedHashSet<>();
--- End diff --
Can we add a null checks around these parts of the `clone` method?
`if (getContentRepositoryStorageUsage() != null) {`
`if (getProvenanceRepositoryStorageUsage() != null) {`
`if (getGarbageCollection() != null) {`
I realize that a couple of these weren't part of your PR but could lead to
an NPE if the DTO isn't fully populated at time of invocation.
> Display provenance repository storage usage in UI
> -------------------------------------------------
>
> Key: NIFI-4341
> URL: https://issues.apache.org/jira/browse/NIFI-4341
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
> Reporter: Pierre Villard
> Assignee: Pierre Villard
> Attachments: clusterView.png, systemDiagView.png
>
>
> Just like we have storage usage information for flow file repository and
> content repository, it'd be interesting to display the same information for
> provenance repository in system diagnostic view and cluster view.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
