Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r139694071
  
    --- Diff: libminifi/include/FlowController.h ---
    @@ -124,14 +123,33 @@ class FlowController : public 
core::controller::ControllerServiceProvider, publi
       virtual bool isRunning() {
         return running_.load();
       }
    +
       // Whether the Flow Controller has already been initialized (loaded flow 
XML)
       virtual bool isInitialized() {
         return initialized_.load();
       }
       // Start to run the Flow Controller which internally start the root 
process group and all its children
    -  virtual bool start();
    +  virtual int16_t start();
    --- End diff --
    
    I completely agree. I've created a ticket to track this: 
https://issues.apache.org/jira/browse/MINIFI-400 MINIFI-399 will encompass 
other structural changes that we can apply


---

Reply via email to