[
https://issues.apache.org/jira/browse/NIFI-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171868#comment-16171868
]
ASF GitHub Bot commented on NIFI-4326:
--------------------------------------
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2111#discussion_r139724038
--- Diff:
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ExtractEmailHeaders.java
---
@@ -103,6 +102,21 @@
.defaultValue("x-mailer")
.build();
+ private static final String STRICT_ADDRESSING_DEFAULT_VALUE = "true";
+ public static final PropertyDescriptor STRICT_ADDRESSING = new
PropertyDescriptor.Builder()
+ .name("STRICT_ADDRESS_PARSING")
+ .displayName("Use Strict Address Parsing")
+ .description("If true, strict address format parsing rules are
applied to mailbox and mailbox list fields, " +
+ "such as \"to\" and \"from\" headers, and FlowFiles
with poorly formed addresses will be routed " +
+ "to the failure relationship, similar to messages that
fail RFC compliant format validation. " +
+ "If false, the processor will extract the contents of
mailbox list headers as comma-separated " +
+ "values without attempting to parse each value as
well-formed Internet mailbox addresses. " +
+ "This is optional and defaults to " +
STRICT_ADDRESSING_DEFAULT_VALUE)
+ .required(false)
+ .defaultValue(STRICT_ADDRESSING_DEFAULT_VALUE)
+ .allowableValues("true", "false")
--- End diff --
I would change this to use the "AllowableValue" class and move some of the
description of "true" vs. "false" behavior from the description field into each
value. Here is an example:
https://github.com/apache/nifi/pull/2148/files#diff-4f399a5e493f124a256ae2740c20f839
> ExtractEmailHeaders.java unhandled Exceptions
> ---------------------------------------------
>
> Key: NIFI-4326
> URL: https://issues.apache.org/jira/browse/NIFI-4326
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.3.0
> Environment: jdk 1.8.0_121-b13
> openjdk 8u131-b11
> Reporter: Benjamin Wood
> Assignee: Benjamin Wood
> Priority: Minor
> Fix For: 1.4.0
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The ExtractEmailHeaders processor throws a NullPointerException if there is
> no TO, CC, and BCC recipients.
> If there are no recipients "originalMessage.getAllRecipients()" returns NULL,
> and not a 0 length array.
> If an address is empty (<> or " ") then getRecipients() will throw an "Empty
> Address" AddressException
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
