[ 
https://issues.apache.org/jira/browse/NIFIREG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173537#comment-16173537
 ] 

ASF GitHub Bot commented on NIFIREG-18:
---------------------------------------

Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/10#discussion_r140031392
  
    --- Diff: 
nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/repository/FlowRepository.java
 ---
    @@ -0,0 +1,34 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry.db.repository;
    +
    +import org.apache.nifi.registry.db.entity.FlowEntity;
    +import org.springframework.data.jpa.repository.Query;
    +import org.springframework.data.repository.PagingAndSortingRepository;
    +import org.springframework.data.repository.query.Param;
    +
    +import java.util.List;
    +
    +/**
    + * Spring Data Repository for FlowEntity.
    + */
    +public interface FlowRepository extends 
PagingAndSortingRepository<FlowEntity,String> {
    +
    +    @Query("SELECT f FROM FlowEntity f WHERE LOWER(f.name) = LOWER(:name)")
    +    List<FlowEntity> findByName(@Param("name") String name);
    --- End diff --
    
    Same as above regarding `@Query` annotation -> `findByNameIgnoreCase`.


> Refactor MetadataProvider to use an embedded database
> -----------------------------------------------------
>
>                 Key: NIFIREG-18
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-18
>             Project: NiFi Registry
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>
> We need to leverage transactions when persisting data to avoid inconsistent 
> states. Currently the MetadataProvider is based on an XML file which doesn't 
> offer much way to rollback an operation. We should switch to using an 
> embedded database.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to