[
https://issues.apache.org/jira/browse/NIFI-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176981#comment-16176981
]
ASF GitHub Bot commented on NIFI-3803:
--------------------------------------
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Thanks for the PR @yuri1969! I had tried implementing this awhile back
allowing the user to tab into the table and then navigate from there. I wasn't
thrilled with the solution has it required the user to tab twice to get focus
into the first visible row. I believe the double tab was required due to the
'focusSink' that `SlickGrid` adds to the DOM [1]. This functionality is already
in your master. In conjunction with your PR, I like the capability much better.
Now the user can navigate from the filter field and from the table if they get
focus into the table via tab (albeit double tab) or clicking on a row.
Just a couple minor comments on the PR.
- I believe these `nfFilteredDialogCommon` needs to be included in
nf-settings for the Add Reporting Task dialog.
- Also, I was wondering if it would be possible for pageDown/pageUp to
select the first/last visible row after navigating. The behavior seems a little
inconsistent currently. If the table has/had focus from clicking on a row, then
the pageDown/pageUp behavior seems right. If it hasn't, the pageDown/pageUp
just navigates the view but does not change the selected row. It would be nice
if the selected row changed with the view regardless if the navigation is being
triggered through `nfFilteredDialogCommon` or through the existing
capabilities. Let me know if you need to me to explain what I'm seeing further.
[1]
https://github.com/mleibman/SlickGrid/blob/bf4705a96c40fea088216034def4d0256a335e65/slick.grid.js#L237
> Allow use of up/down arrow keys during selection in Add Processor dialog
> ------------------------------------------------------------------------
>
> Key: NIFI-3803
> URL: https://issues.apache.org/jira/browse/NIFI-3803
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
> Affects Versions: 1.2.0
> Reporter: Andy LoPresto
> Priority: Trivial
> Labels: ui
>
> In the Add Processor dialog, it would be convenient to be able to use the up
> and down arrow keys to select the filtered results after typing the first few
> characters of the desired component name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
