[
https://issues.apache.org/jira/browse/NIFI-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189817#comment-16189817
]
ASF GitHub Bot commented on NIFI-1547:
--------------------------------------
GitHub user jmark99 opened a pull request:
https://github.com/apache/nifi/pull/2192
NIFI-1547: DistributedMapCacheServer: Ambiguous error on misconfiguration
misconfiguration
Updated PersistentMapCache constructor in PersistentMapCache.java to
catch an OverlappingFileLockException and present a more useful error
message before propagating the exception forward. The log message alerts
user to possible duplicated persistencePath in call to
PersistentMapCache.
Created a test method to verify the exception is thrown as expected.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmark99/nifi NIFI-1547
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2192
----
commit cd7a8fc91827688032c57a1955b5443cb588b653
Author: Mark Owens <jmark...@gmail.com>
Date: 2017-10-03T14:48:42Z
NIFI-1547: DistributedMapCacheServer: Ambiguous error on
misconfiguration
Updated PersistentMapCache constructor in PersistentMapCache.java to
catch an OverlappingFileLockException and present a more useful error
message before propagating the exception forward. The log message alerts
user to possible duplicated persistencePath in call to
PersistentMapCache.
Created a test method to verify the exception is thrown as expected.
----
> DistributedMapCacheServer: Ambiguous error on misconfiguration
> --------------------------------------------------------------
>
> Key: NIFI-1547
> URL: https://issues.apache.org/jira/browse/NIFI-1547
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Brandon DeVries
> Assignee: Mark Owens
> Priority: Minor
>
> If a DistributedMapCacheServer's "Persistence Directory" is set to the same
> location as another DistributedMapCacheServer (or another controller service
> with a "Persistence Directory") only one will enable successfully. The
> other(s) will get an OverlappingFileLockException. Consider catching this
> exception \[1\] and providing additional information (e.g. check the lock
> location / "Persistence Directory").
> \[1\]
> https://github.com/apache/nifi/blob/31fba6b3332978ca2f6a1d693f6053d719fb9daa/nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-services-bundle/nifi-distributed-cache-server/src/main/java/org/apache/nifi/distributed/cache/server/map/PersistentMapCache.java#L44
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
