[
https://issues.apache.org/jira/browse/NIFI-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190237#comment-16190237
]
ASF GitHub Bot commented on NIFI-4461:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2193
NIFI-4461: When reading from socket channel use blocking mode instead…
… of sleeping; when writing, use a far smaller sleep duration
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4461
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2193
----
commit 0cefa7ee8de2abf72008444c5edd19ce96f782d4
Author: Mark Payne <marka...@hotmail.com>
Date: 2017-10-03T19:55:02Z
NIFI-4461: When reading from socket channel use blocking mode instead of
sleeping; when writing, use a far smaller sleep duration
----
> DistributedMapCacheClient/Server are inefficient when waiting for data to be
> received from socket
> -------------------------------------------------------------------------------------------------
>
> Key: NIFI-4461
> URL: https://issues.apache.org/jira/browse/NIFI-4461
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.5.0
>
>
> The DistributedMapCacheClient and DistributedMapCacheServer use the
> SocketChannelInputStream and SSLSocketChannelInputStream (and output streams)
> for communicating over a socket in non-blocking mode. This is done to allow a
> timeout to occur on a socket write. However, when reading from the socket, it
> ends up calling Thread.sleep(10, TimeUnit.MILLISECONDS) when there is no data
> available, and that can result in extremely slow performance. Instead, we
> should using blocking mode when receiving data because it will throw a
> timeout exception as we desire. When writing, we should continue using
> non-blocking mode but sleep for far less than 10 milliseconds.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
