[ 
https://issues.apache.org/jira/browse/NIFIREG-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190280#comment-16190280
 ] 

ASF GitHub Bot commented on NIFIREG-9:
--------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/14#discussion_r142475289
  
    --- Diff: 
nifi-registry-security/src/main/java/org/apache/nifi/registry/authorization/AccessPolicy.java
 ---
    @@ -0,0 +1,367 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry.authorization;
    +
    +import java.nio.charset.StandardCharsets;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import java.util.Objects;
    +import java.util.Set;
    +import java.util.UUID;
    +
    +/**
    + * Defines a policy for a set of userIdentifiers to perform a set of 
actions on a given resource.
    + */
    +public class AccessPolicy {
    --- End diff --
    
    I know this would be a tedious change, but what do you think about 
splitting out all of the interfaces/domain objects from nifi-registry-security 
into nifi-registry-security-api?
    
    My thinking is that nifi-registry-security-api would live in the lib 
directory and be something that other people would implement against, where as 
nifi-registry-security would be bundled under the WAR for nifi-registry-web-api.


> Define web REST API endpoints for user, group, and policy management
> --------------------------------------------------------------------
>
>                 Key: NIFIREG-9
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-9
>             Project: NiFi Registry
>          Issue Type: New Feature
>            Reporter: Kevin Doran
>            Assignee: Kevin Doran
>             Fix For: 0.0.1
>
>
> NIFIREG-8 defined web REST API endpoints for domain objects such as buckets 
> and flows.
> This ticket scopes work to build on that by adding endpoints for additional 
> resources to facilitate user, group, and policy management.
> The interface for user, group, and policy management will be based on the 
> NiFi API so as to minimize the effort for NiFi API clients to be reused for 
> NiFi Registry.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to