[ 
https://issues.apache.org/jira/browse/NIFI-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192590#comment-16192590
 ] 

ASF GitHub Bot commented on NIFI-4465:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2194#discussion_r142869816
  
    --- Diff: 
nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/main/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessor.java
 ---
    @@ -101,6 +97,24 @@
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
                 .build();
     
    +    static final PropertyDescriptor COLUMN_DELIMITER = new 
PropertyDescriptor.Builder()
    +            .name("excel-csv-column-delimiter")
    +            .displayName("Column Delimiter")
    +            .description("Character(s) used to separate columns of data in 
the CSV file. Special characters should use the '\\u' notation.")
    +            .required(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .defaultValue(",")
    +            .build();
    +
    +    static final PropertyDescriptor RECORD_DELIMITER = new 
PropertyDescriptor.Builder()
    +            .name("excel-csv-record-delimiter")
    +            .displayName("Record Delimiter")
    +            .description("Character(s) used to separate rows of data in 
the CSV file. For line return enter \\n in this field. Special characters 
should use the '\\u' notation.")
    +            .required(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .defaultValue("\\n")
    +            .build();
    --- End diff --
    
    Is there any reason that we don't support EL here?


> ConvertExcelToCSV Data Formatting and Delimiters
> ------------------------------------------------
>
>                 Key: NIFI-4465
>                 URL: https://issues.apache.org/jira/browse/NIFI-4465
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> The ConvertExcelToCSV Processor does not output cell values using the 
> formatting set in Excel.
> There are also no delimiter options available for column/record delimiting.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to