Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/92#discussion_r143098180
  
    --- Diff: 
minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/pom.xml
 ---
    @@ -25,6 +25,61 @@
         <description>holds common resources used to build 
installers</description>
         <build>
             <plugins>
    +           <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-antrun-plugin</artifactId>
    +                           <dependencies>
    +                                   <dependency>
    +                                           <groupId>ant-contrib</groupId>
    +                                           
<artifactId>ant-contrib</artifactId>
    +                                           <version>20020829</version>
    +                                   </dependency>
    +                           </dependencies>
    +                           <executions>
    +                                   <execution>
    +                                           <id>download-commons-daemon</id>
    +                                           <phase>compile</phase>
    +                                           <goals>
    +                                                   <goal>run</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   <tasks>
    +                                                           <taskdef 
resource="net/sf/antcontrib/antcontrib.properties" />
    +                                                           <if>
    +                                                                   
<available file="${basedir}/src/main/resources/bin/minifiw.exe" />
    +                                                                   <then>
    +                                                                           
<echo message="Skipping download of commons-daemon." />
    +                                                                   </then>
    +                                                                   <else>
    +                                                                           
<echo message="Downloading Commons Daemon Windows binaries." />
    +                                                                           
<get
    +                                                                           
        
src="http://www.apache.org/dist/commons/daemon/binaries/windows/commons-daemon-1.0.15-bin-windows.zip";
    +                                                                           
        dest="${java.io.tmpdir}/commons-daemon-1.0.15-bin-windows.zip"
    +                                                                           
        skipexisting="true" />
    +                                                                           
<get
    +                                                                           
        
src="http://www.apache.org/dist/commons/daemon/binaries/windows/commons-daemon-1.0.15-bin-windows.zip.md5";
    +                                                                           
        dest="${java.io.tmpdir}/commons-daemon-1.0.15-bin-windows.zip.md5"
    +                                                                           
        skipexisting="true" />
    +                                                                           
<local name="checksum.matches" />
    +                                                                           
<checksum file="${java.io.tmpdir}/commons-daemon-1.0.15-bin-windows.zip" 
fileext=".md5" format="MD5SUM" verifyProperty="checksum.matches"/>
    --- End diff --
    
    Looks they (commons-daemon_ provide a sha1, but we could certainly 
calculate our own 256 or 512.


---

Reply via email to