[
https://issues.apache.org/jira/browse/NIFI-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195150#comment-16195150
]
ASF GitHub Bot commented on NIFI-4371:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r143279988
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java
---
@@ -290,6 +292,9 @@ public void process(final OutputStream out) throws
IOException {
}
}
+ // set query timeout
+ st.setQueryTimeout(queryTimeout);
--- End diff --
I get the point of the customValidate but I'd keep its check but mark it as
valid whether the timeout method is supported or not. YOu can set some
processor instance boolean to advise whether it is supported then in this
call/check set the timeout if it is and ignore it if not. Otherwise we're
requiring them to use a version of hive which supports it and that seems a
little heavy handed. It is probably a good idea to do the current validation
logic in some other lifecycle call like 'onAdded' or something, warn if
timeouts not supported and point out hanging threads are possible, and keep
going.
> Add support for query timeout in Hive processors
> ------------------------------------------------
>
> Key: NIFI-4371
> URL: https://issues.apache.org/jira/browse/NIFI-4371
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Pierre Villard
> Assignee: Pierre Villard
> Attachments: Screen Shot 2017-09-09 at 4.31.21 PM.png, Screen Shot
> 2017-09-09 at 6.38.51 PM.png, Screen Shot 2017-09-09 at 6.40.48 PM.png
>
>
> With HIVE-4924 it is possible to set a query timeout when executing a query
> against Hive (starting with Hive 2.1). Right now, NiFi is built using Hive
> 1.2.1 and this feature is not available by default (the method is not
> implemented in the driver). However, if building NiFi with specific profiles
> this feature can be used.
> The objective is to expose the query timeout parameter in the processor and
> enable expression language. If the version of the driver is not implementing
> the query timeout the processor will be in invalid state (unless expression
> language is used, and in this case, the flow file will be routed to the
> failure relationship).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
