[
https://issues.apache.org/jira/browse/MINIFICPP-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196143#comment-16196143
]
ASF GitHub Bot commented on MINIFICPP-254:
------------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/143
MINIFICPP-254: Resolve odd naming of isRunning variable so that it's …
…clear we do not lock when we are running
Originally identified by Fredrick Stakem.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-254
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #143
----
commit d0da1a8c6d0c66f011c30702070efa88b4ccbe32
Author: Marc Parisi <[email protected]>
Date: 2017-10-08T14:43:54Z
MINIFICPP-254: Resolve odd naming of isRunning variable so that it's clear
we do not lock when we are running
Originally identified by Fredrick Stakem.
----
> Connectable lock incorrect
> --------------------------
>
> Key: MINIFICPP-254
> URL: https://issues.apache.org/jira/browse/MINIFICPP-254
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Fredrick Stakem
> Assignee: marco polo
> Priority: Minor
>
> On class Connectable line 68 you define a lock required if it is running in
> function isSupportedRelationship(). If the Connectable is running then
> relationship_ does not change in the code. The relationship_ only can be
> changed when the state is not running. Is this backwards?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
