[
https://issues.apache.org/jira/browse/MINIFICPP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234634#comment-16234634
]
ASF GitHub Bot commented on MINIFICPP-280:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r148365280
--- Diff: thirdparty/google-styleguide/run_linter.sh ---
@@ -14,16 +15,31 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-# ./run_linter <includedir> <srcdir>
-#!/bin/bash
-if [ "$(uname)" == "Darwin" ]; then
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+# ./run_linter <includedir1> <includedir2> ... <includedirN> -- <srcdir1>
<srcdir2> ... <srcdirN>
--- End diff --
I like this. I was hoping to make these linter changes following our
upcoming release. I also like what you did with tests and was toying with that
but didn't want to jump to that because I had a full plate with other features
and cmake additions I really appreciate this PR as it helps us tremendously.
I'll run through it. May not make it through to this release but we'll get this
reviewed and merged as it's super helpful.
> Various refactoring and improvements
> ------------------------------------
>
> Key: MINIFICPP-280
> URL: https://issues.apache.org/jira/browse/MINIFICPP-280
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
> Priority: Minor
>
> * move extension tests into their respective folders
> * separate source and header files
> * remove unnecessary or nonexisting include directories
> * run linter on extension source files as part of linter target
> * clean up extensions according to linter
> * add ability to specify more than one include and source folder for linter
> * build catch main() and spdlib as shared objects for all tests (faster
> build!)
> * cmake doesn't know PRIVATE BEFORE, only BEFORE PRIVATE
> * borrow port changes to tests from MINIFICPP-60 for parallel testing
> * enable parallel testing in travis config
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
