Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151569308
  
    --- Diff: extensions/libarchive/FocusArchiveEntry.cpp ---
    @@ -295,7 +260,9 @@ int64_t 
FocusArchiveEntry::ReadCallback::process(std::shared_ptr<io::BaseStream>
       return nlen;
     }
     
    -FocusArchiveEntry::ReadCallback::ReadCallback(core::Processor 
*processor,fileutils::FileManager *file_man, ArchiveMetadata *archiveMetadata)
    --- End diff --
    
    Our line length is 200. We haven't merged your changes to lint the 
extensions but you may want to limit these types of changes to reduce later 
changes. 


---

Reply via email to