[ 
https://issues.apache.org/jira/browse/NIFI-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267522#comment-16267522
 ] 

ASF GitHub Bot commented on NIFI-4333:
--------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2161#discussion_r153320426
  
    --- Diff: nifi-toolkit/nifi-toolkit-assembly/docker/Dockerfile ---
    @@ -0,0 +1,48 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements. See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership. The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License. You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied. See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +#
    +
    +FROM openjdk:8-jre-alpine
    +LABEL maintainer "Apache NiFi <d...@nifi.apache.org>"
    +
    +ARG UID=1000
    +ARG GID=1000
    +ARG NIFI_TOOLKIT_VERSION=1.4.0-SNAPSHOT
    --- End diff --
    
    @MikeThomsen Will evaluate the latter but given how the structure of docker 
images is currently composed this is needed as it will be making use of the 
generated nifi toolkit as part of the build which will be a SNAPSHOT.
    
    The Dockerfile.hub version is devoid of this given that it only is built 
against generated releases.


> Dockerize NiFi Toolkit
> ----------------------
>
>                 Key: NIFI-4333
>                 URL: https://issues.apache.org/jira/browse/NIFI-4333
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Docker
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>
> It would be helpful to have a TLS Toolkit image to work in conjunction with 
> NiFI and would help in orchestration of clustered instances as well as 
> provisioning security items.
> As this is one assembly, we should support all tooling provided through one 
> image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to