[ https://issues.apache.org/jira/browse/NIFI-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268154#comment-16268154 ]
ASF GitHub Bot commented on NIFI-4256: -------------------------------------- Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/2291#discussion_r153396684 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java --- @@ -125,16 +125,31 @@ new AllowableValue("S3SignerType", "Signature v2")) .defaultValue("Default Signature") .build(); + + public static final PropertyDescriptor CLIENT_SERVICE = new PropertyDescriptor.Builder() + .name("Client Service") --- End diff -- Name should be a machine-readable key like "client-service" with a human-readable displayName like "Client Service". I know this has not been done previously in this file, but we should try to do it going forward. > Add support for all AWS S3 Encryption Options > --------------------------------------------- > > Key: NIFI-4256 > URL: https://issues.apache.org/jira/browse/NIFI-4256 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework > Affects Versions: 1.2.0 > Reporter: Franco > Labels: aws, aws-s3, security > > NiFi currently only supportsĀ SSE-S3 encryption (AES256). > Support needs to be added for: > * SSE-S3 > * SSE-KMS > * SSE-C > * CSE-KMS CMK > * CSE-Master Key > With all of the appropriate configuration options and such that SSE is > available only for PutS3Object whilst CSE is available also for FetchS3Object. > Given that this will add another 20 or so UI properties the intention is to > split it into a Client Side Encryption Service and Server Side Encryption > Service. This will allow users to reuse "encryption" across different > workflows. > Existing flows using the Server Side Encryption option will still work as is > but will be overridden if a service is added. -- This message was sent by Atlassian JIRA (v6.4.14#64029)