[ https://issues.apache.org/jira/browse/MINIFICPP-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286442#comment-16286442 ]
ASF GitHub Bot commented on MINIFICPP-41: ----------------------------------------- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/217#discussion_r156175860 --- Diff: libminifi/src/capi/api.cpp --- @@ -0,0 +1,251 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include <string> +#include <map> +#include <memory> +#include <utility> +#include "core/Core.h" +#include "capi/api.h" +#include "capi/expect.h" +#include "capi/Instance.h" +#include "capi/Plan.h" +#include "ResourceClaim.h" + +/** + * Creates a NiFi Instance from the url and output port. + * @param url http URL for NiFi instance + * @param port Remote output port. + */ +nifi_instance *create_instance(char *url, nifi_port *port) { + minifi::setDefaultDirectory(DEFAULT_CONTENT_DIRECTORY); --- End diff -- Are you referring to default directory or an instance? There can be many instances and connections to nifi > Create C++ library for core API > ------------------------------- > > Key: MINIFICPP-41 > URL: https://issues.apache.org/jira/browse/MINIFICPP-41 > Project: NiFi MiNiFi C++ > Issue Type: Task > Reporter: Aldrin Piri > > To make it possible for folks to create extensions and build on top of the > MiNiFi C++ framework, the establishment of a core API library extracted from > the existing codebase that can be linked should be provided. -- This message was sent by Atlassian JIRA (v6.4.14#64029)