[ https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313922#comment-16313922 ]
ASF GitHub Bot commented on NIFI-4697: -------------------------------------- GitHub user mosermw opened a pull request: https://github.com/apache/nifi/pull/2381 NIFI-4697 clarified some PostHTTP documentation Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [N/A] Have you written or updated unit tests to verify your changes? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [X] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mosermw/nifi nifi-4697 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2381.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2381 ---- commit 3f503b890aa0278b42a9d3e43c75a37dab430e38 Author: Mike Moser <mosermw@...> Date: 2018-01-05T21:13:05Z NIFI-4697 clarified some PostHTTP documentation ---- > PostHTTP: correct documentation > ------------------------------- > > Key: NIFI-4697 > URL: https://issues.apache.org/jira/browse/NIFI-4697 > Project: Apache NiFi > Issue Type: Improvement > Affects Versions: 1.4.0 > Reporter: Brandon DeVries > Assignee: Michael Hogue > Priority: Minor > > The description of the URL property of PostHTTP says > "The URL to POST to. The first part of the URL must be static. However, the > path of the URL may be defined using the Attribute Expression Language. " > This does not appear to be true. We should modify to something like "The URL > to POST to." > ...or, someone can point out to me why I'm wrong in saying it's wrong... -- This message was sent by Atlassian JIRA (v6.4.14#64029)