[
https://issues.apache.org/jira/browse/NIFI-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317098#comment-16317098
]
ASF GitHub Bot commented on NIFI-4750:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2387
NIFI-4750 Ensuring preDestruction is called on authorizer and appropr…
…iate policy/user-group providers
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-4750
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2387
----
commit f9d1faeca4c42246595e85e5202ae7c484182ca2
Author: Bryan Bende <bbende@...>
Date: 2018-01-08T21:21:03Z
NIFI-4750 Ensuring preDestruction is called on authorizer and appropriate
policy/user-group providers
----
> Authorizer not properly shutting down
> -------------------------------------
>
> Key: NIFI-4750
> URL: https://issues.apache.org/jira/browse/NIFI-4750
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
>
> I was running a NiFi instance configured with the StandardManagedAuthorizer,
> using a file-based policy provider, and a composite user-group-provider
> (file-based and ldap providers).
> Whenever I shutdown I noticed it was taking a long time and forcibly shutting
> down. A thread dump showed that the Ldap sync thread was still running which
> led me to look at how the auhorizers shutdown.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
