Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/230#discussion_r160268671
  
    --- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
    @@ -40,13 +40,18 @@ namespace core {
     #define CONFIG_YAML_CONNECTIONS_KEY "Connections"
     #define CONFIG_YAML_CONTROLLER_SERVICES_KEY "Controller Services"
     #define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY "Remote Processing Groups"
    +#define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY_V3 "Remote Process Groups"
     #define CONFIG_YAML_PROVENANCE_REPORT_KEY "Provenance Reporting"
     
     class YamlConfiguration : public FlowConfiguration {
     
      public:
    -  explicit YamlConfiguration(std::shared_ptr<core::Repository> repo, 
std::shared_ptr<core::Repository> flow_file_repo, 
std::shared_ptr<core::ContentRepository> content_repo,
    -                             std::shared_ptr<io::StreamFactory> 
stream_factory, std::shared_ptr<Configure> configuration, const std::string 
path = DEFAULT_FLOW_YAML_FILE_NAME)
    +  explicit YamlConfiguration(std::shared_ptr<core::Repository> repo,
    --- End diff --
    
    Did you shorten the line length? I think we abide by 200 characters as per 
nifi.


---

Reply via email to